-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: automate metrics list documentation #9950
Conversation
5145ae3
to
2c65b34
Compare
b45a569
to
dc25387
Compare
Codecov Report
@@ Coverage Diff @@
## master #9950 +/- ##
=========================================
- Coverage 69.12% 69.1% -0.02%
=========================================
Files 386 386
Lines 35784 35784
=========================================
- Hits 24735 24730 -5
- Misses 9232 9244 +12
+ Partials 1817 1810 -7
Continue to review full report at Codecov.
|
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
lgtm. Thanks @gyuho , very useful tool. I will start to play with it. I will back port it to 3.3. and 3.2. I will check if it's OK to back port to 3.1 or if there is any modification needed. |
@wenjiaswe I am ok with backporting it but since http://etcd.readthedocs.io/en/latest/ is only serving on master branch for now, old metrics won't be shown for awhile. It would be helpful if you can regenerate those metrics using |
OK, got it. |
Currently, need manual cluster set-up to find all available metrics, thus cannot be documented. Automatically document all available metrics, with embedded etcd for master branch or specified endpoints. This will make tracking metrics changes much easier.
Following PR should initialize
grpc_server_msg_sent_total
for all available RPCs (#8878). Right now, v3.1 and v3.2 only show the ones that have been requested.Sample rendering (will be served via https://etcd.readthedocs.io/en/latest once merged)
For #9438.